CI is automatically triggering the following test suites:

•     ci:test:sf

Test suite sf has been triggered on http://test-1-31

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Ran com.liferay.source.formatter at released version 1.0.1544.
*The latest version has not been released.

ci:test:frontend-data-set

Test suite frontend-data-set has been triggered on http://test-1-25

❌ ci:test:frontend-data-set - 3 out of 6 jobs passed in 56 minutes

Test bundle downloads:

• liferay-portal-bundle-tomcat.tar.gz

Great catch @thektan , my bad.

I'd like to review the activateFilter utility as well, because that one does mutate the filter. There is a case (getInitialViewState) where original code mutated the filter and I'd say that's why I wrongly implemented utilities in that way. Here returning a new object is not strictly needed but won't hurt.

The other usage is a bit more convoluted, I believe this one would benefit from returning a new object. could you please take a deeper look? Thx

@dsanz I'm going to keep activateFilter the same. I was attempting to make it avoid any mutations, but it resulted in more issues with the filters not even applying anymore. I noticed places require possibly bigger changes like in Filter.tsx where it depends on the mutation happening.

Also it looks like activateFilter was implemented the same way it was before. With the mutations.

For example:

• Filter.tsx: https://github.com/liferay/liferay-portal/blob/f9fdd0193e875e15aac15cc44bbbcaf9301ac435/modules/apps/frontend-data-set/frontend-data-set-web/src/main/resources/META-INF/resources/management_bar/controls/filters/Filter.tsx#L96-L116
• FrontendDataSet.tsx: https://github.com/liferay/liferay-portal/blob/f9fdd0193e875e15aac15cc44bbbcaf9301ac435/modules/apps/frontend-data-set/frontend-data-set-web/src/main/resources/META-INF/resources/FrontendDataSet.tsx#L294-L308

Added a change to fix the filter resume not fully clearing.

Also might be something broken with the forward/back history navigation, but I can't reliably reproduce it. It seems sometimes the forward history gets wiped out when you hit back navigation to the initial state (plus it gets suck there where continually hitting back navigation does nothing). 🙃

Mainly looking at this test specifically:

ci:test:frontend-data-set

Test suite frontend-data-set has been triggered on http://test-1-34

❌ ci:test:frontend-data-set - 3 out of 6 jobs passed in 1 hour 6 minutes

Test bundle downloads:

• liferay-portal-bundle-tomcat.tar.gz

ci:test:sf

ci:test:relevant

Test suite sf has been triggered on http://test-1-37

Test suite relevant has been triggered on http://test-1-37

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Ran com.liferay.source.formatter at released version 1.0.1545.

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 14 out of 16 jobs passed in 1 hour 3 minutes

Test bundle downloads:

• liferay-portal-bundle-tomcat.tar.gz

@dsanz @markocikos As a heads up I changed the solution to only return a new object since the config in URL navigation would break (when clearing the filters, navigating back and forward if the filter wasn't mutated 🙃.

Looks like this allows everything to work as expected now:

export function deactivateFilter(filter: any) {
	filter.active = false;
	filter.odataFilterString = undefined;
	filter.selectedData = undefined;

	return {
		...filter,
	};
}

ci:forward:force

CI is automatically triggering the following test suites:

•     ci:test:relevant
•     ci:test:sf
•     ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

•     ci:test:relevant
•     ci:test:sf
  AND If the following test suites pass:
•     ci:test:stable

Skipping previously completed test suites:

• ci:test:relevant
• ci:test:sf
  AND Skipping previously passed test suites:
• ci:test:stable

Test suite default has been triggered on http://test-1-26

All required test suite(s) completed.
Forwarding pull request to brianchandotcom.
Console

Pull request has been successfully forwarded to brianchandotcom#166833
Console